Skip to content

refactor(datepicker): adapt custom header demo for Ivy #15458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 1 commit into from
Mar 14, 2019
Merged

refactor(datepicker): adapt custom header demo for Ivy #15458

mmalerba merged 1 commit into from
Mar 14, 2019

Conversation

@marclaval
Copy link
Contributor

@marclaval marclaval commented Mar 13, 2019

In Ivy, @host() no longer looks in module injector. This breaks this demo.

@marclaval marclaval requested a review from mmalerba as a code owner March 13, 2019 15:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@marclaval marclaval mentioned this pull request Mar 13, 2019
Merged
@marclaval marclaval force-pushed the fixDatePickerDemo branch 2 times, most recently from 538b259 to e18b1d2 Compare March 13, 2019 15:50
crisbeto
crisbeto approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 13, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Mar 13, 2019

I think there's an example with a similar failure that you might want to update as well: "Datepicker with custom calendar header"

@marclaval marclaval requested a review from jelbourn as a code owner March 14, 2019 09:05
@marclaval
Copy link
Contributor Author

marclaval commented Mar 14, 2019

I've updated the example, PTAL

@mmalerba mmalerba merged commit db4e2e2 into angular:master Mar 14, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
@marclaval @mmalerba
refactor(datepicker): adapt custom header demo for Ivy (#15458)
3f8a443
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@marclaval
refactor(datepicker): adapt custom header demo for Ivy (angular#15458)
eca118f
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marclaval @mmalerba @crisbeto @googlebot