Skip to content

chore(typescript): uniformly access all index sigs with index access. #15523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewseguin merged 1 commit into from
Mar 20, 2019
Merged

chore(typescript): uniformly access all index sigs with index access. #15523

andrewseguin merged 1 commit into from
Mar 20, 2019

Conversation

@rkirov
Copy link
Contributor

@rkirov rkirov commented Mar 19, 2019

This is a follow up to #15206,
with these two changes all of material in conforming.

A build-time check to enforce this is part of tsetse -
https://tsetse.info/property-renaming-safe but I don't know how to turn
it on for this repositories bazel builds.

@rkirov
chore(typescript): uniformly access all index sigs with index access.
3a7bb7b 
This is a follow up to angular#15206,
with these two changes all of material in conforming.

A build-time check to enforce this is part of tsetse -
https://tsetse.info/property-renaming-safe but I don't know how to turn
it on for this repositories bazel builds.
@rkirov rkirov requested a review from crisbeto March 19, 2019 00:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2019
crisbeto
crisbeto approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 19, 2019
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@andrewseguin andrewseguin merged commit bd66e5c into angular:master Mar 20, 2019
@andrewseguin andrewseguin added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Mar 25, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rkirov @crisbeto @googlebot @andrewseguin