Skip to content

fix:(tabs) add call for rechecking tab scroll distance #16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lau32 wants to merge 1 commit into from
Closed

fix:(tabs) add call for rechecking tab scroll distance #16200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/material/tabs/tab-header.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,34 @@ describe('MatTabHeader', () => {
expect(tabHeaderElement.classList).toContain(enabledClass);
});

it('should scroll to last tab', async(() => {
const tabs = [
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
{label: 'tab one'},
];

fixture = TestBed.createComponent(SimpleTabHeaderApp);
fixture.detectChanges();

const component = fixture.componentInstance;
component.tabs = tabs;
component.selectedIndex = tabs.length - 1;
fixture.detectChanges();

fixture.whenRenderingDone()
.then(() => {
expect(component.tabHeader._disableScrollAfter).toBeTruthy();
expect(component.tabHeader.scrollDistance)
.toEqual(component.tabHeader._getMaxScrollDistance());
});
}));

});
});

Expand Down
1 change: 1 addition & 0 deletions src/material/tabs/tab-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ export class MatTabHeader extends _MatTabHeaderMixinBase
const dirChange = this._dir ? this._dir.change : observableOf(null);
const resize = this._viewportRuler.change(150);
const realign = () => {
this._scrollToLabel(this._selectedIndex);
this.updatePagination();
this._alignInkBarToSelectedTab();
};
Expand Down