build: do generate invalid semver versions for snapshot builds#17267
Merged
mmalerba merged 1 commit intoangular:masterfrom Oct 2, 2019
Merged
Conversation
Apparently there is a long-standing issue in the snapshot builds
where we generate invalid versions if the snapshot SHA starts with
zero's. In order to fix this, we need to ensure that the commit SHA is
part of a version segment that starts with text (i.e. `-sha-{val}`).
Fixes angular#17264
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
approved these changes
Oct 2, 2019
Splaktar
reviewed
Oct 2, 2019
| @@ -42,7 +42,12 @@ commitAuthorEmail=$(git --no-pager show -s --format='%ae' HEAD) | |||
| commitMessage=$(git log --oneline -n 1) | |||
| commitTag="${buildVersion}-${commitSha}" | |||
Contributor
There was a problem hiding this comment.
We should consider removing this line as it isn't used anymore.
2 tasks
mmalerba
pushed a commit
that referenced
this pull request
Oct 8, 2019
Apparently there is a long-standing issue in the snapshot builds
where we generate invalid versions if the snapshot SHA starts with
zero's. In order to fix this, we need to ensure that the commit SHA is
part of a version segment that starts with text (i.e. `-sha-{val}`).
Fixes #17264
(cherry picked from commit 94cec9f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently there is a long-standing issue in the snapshot builds
where we generate invalid versions if the snapshot SHA starts with
zero's. In order to fix this, we need to ensure that the commit SHA is
part of a version segment that starts with text (i.e.
-sha-{val}).This happens rarely, but it should be a good idea to fix this.
Note: I guess this should also go into the patch branch for the
8.2.xdocs-content.Fixes #17264