docs: add missing documentation for error state properties #23010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All components relying on the `mixinErrorState` currently lack descriptions for the mixin-defined properties. This commit adds JSDoc descriptions for these properties. Also adds a small internal note about why `stateChanges` is declared as part of the mixin.
devversion
added
docs
google-cla
bot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
All components relying on the `mixinErrorState` currently lack descriptions for the mixin-defined properties. This commit adds JSDoc descriptions for these properties. Also adds a small internal note about why `stateChanges` is declared as part of the mixin. (cherry picked from commit 136fb5a)
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
All components relying on the `mixinErrorState` currently lack descriptions for the mixin-defined properties. This commit adds JSDoc descriptions for these properties. Also adds a small internal note about why `stateChanges` is declared as part of the mixin. (cherry picked from commit 136fb5a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit from #22875 so that we can fix the missing documentation without introducing a "technically" breaking change. The other PR will remain open for discussion & potentially for a new major if we agree on changing how
stateChangesis defined.