feat(material-experimental/mdc-chips): switch to evolution API by crisbeto · Pull Request #23931 · angular/components

crisbeto · 2021-11-09T13:37:18Z

Reworks the MDC-based chips to use the new evolution API instead of the deprecated one we're currently using. The new API comes with a lot of markup changes and some behavior differences.

The new API also allows to remove the GridKeyManager, because the keyboard navigation is handled correctly by MDC.

jelbourn

Got about halfway through so far

jelbourn · 2021-11-17T00:10:56Z

+@mixin _base-chip($is-dark) {
+  $on-surface-state-content: if($is-dark, mdc-color-palette.$grey-50, mdc-color-palette.$grey-900);
+  $surface:
+    color.mix(mdc-theme-color.prop-value(on-surface), mdc-theme-color.prop-value(surface), 12%);


Should we add a comment here to explain why we're doing the color mix?

I don't think there's a good explanation tbh, we had the mixing there with the previous implementation so I moved it over to the new one.

jelbourn · 2021-11-17T00:25:17Z

+      // which overrides our own handling. If we detect such a case, assign it to the same property
+      // as the Angular binding in order to maintain consistency.
+      if (name === 'tabindex') {
+        this._updateTabindex(parseInt(value));


Should we use Number(value) here instead? IIRC Number is more predictable (e.g. doesn't interpret a leading 0 as octal)

We've been using parseInt for cases like this everywhere else so I went along with it. I also think that it's unlikely for somebody to write out tabindex="007".

jelbourn · 2021-11-17T00:27:20Z

+    // and error prone, and we need them in several places.
+    const classList = _elementRef.nativeElement.classList;
+    const actionType = this._foundation.actionType();
+    classList.add('mdc-evolution-chip__action', 'mat-mdc-chip-action');


I don't 100% follow- why not set these classes in the host block?

There were two reasons when I was working on this initially:

We still had to support ViewEngine which meant that I would've had to repeat the class bindings in two other places.

I wouldn't have been able to use the enum values in the host block.

I think that both of these issues are resolved with Ivy though.

jelbourn · 2021-11-17T00:27:59Z

+  static ngAcceptInputType_disabled: BooleanInput;
+  static ngAcceptInputType_tabIndex: NumberInput;


We can drop these now, right?

There were some internal issues with #23606 so I decided to keep them here.

jelbourn · 2021-11-17T00:29:31Z

+      // MDC sets the tabindex directly on the DOM node when the user is navigating which means
+      // that we may end up with a `0` value from a previous interaction. We reset it manually
+      // here to ensure that the state is correct.


Should we file an issue for this?

This is working as expected, as far as MDC is concerned. I don't think that it makes sense for people to customize the tabindex here to begin with, but we need it for backwards compatibility.

crisbeto

I've addressed the feedback so far.

crisbeto · 2021-11-17T08:04:57Z

+@mixin _base-chip($is-dark) {
+  $on-surface-state-content: if($is-dark, mdc-color-palette.$grey-50, mdc-color-palette.$grey-900);
+  $surface:
+    color.mix(mdc-theme-color.prop-value(on-surface), mdc-theme-color.prop-value(surface), 12%);


I don't think there's a good explanation tbh, we had the mixing there with the previous implementation so I moved it over to the new one.

crisbeto · 2021-11-17T08:12:18Z

+      // which overrides our own handling. If we detect such a case, assign it to the same property
+      // as the Angular binding in order to maintain consistency.
+      if (name === 'tabindex') {
+        this._updateTabindex(parseInt(value));


We've been using parseInt for cases like this everywhere else so I went along with it. I also think that it's unlikely for somebody to write out tabindex="007".

crisbeto · 2021-11-17T08:17:09Z

+    // and error prone, and we need them in several places.
+    const classList = _elementRef.nativeElement.classList;
+    const actionType = this._foundation.actionType();
+    classList.add('mdc-evolution-chip__action', 'mat-mdc-chip-action');


There were two reasons when I was working on this initially:

We still had to support ViewEngine which meant that I would've had to repeat the class bindings in two other places.

I wouldn't have been able to use the enum values in the host block.

I think that both of these issues are resolved with Ivy though.

crisbeto · 2021-11-17T08:22:10Z

+  static ngAcceptInputType_disabled: BooleanInput;
+  static ngAcceptInputType_tabIndex: NumberInput;


There were some internal issues with #23606 so I decided to keep them here.

crisbeto · 2021-11-17T08:23:31Z

+      // MDC sets the tabindex directly on the DOM node when the user is navigating which means
+      // that we may end up with a `0` value from a previous interaction. We reset it manually
+      // here to ensure that the state is correct.


This is working as expected, as far as MDC is concerned. I don't think that it makes sense for people to customize the tabindex here to begin with, but we need it for backwards compatibility.

jelbourn

lgtm

crisbeto · 2021-12-27T07:12:31Z

Heads-up: I've pushed a second commit that simplifies the theming setup for the chips. The previous approach that was using the theme-styles mixin produced very specific CSS which required a lot of hacks internally and added about 35kb of unnecessary CSS to the dev app theme. The new approach only includes the mixins that we need (still public APIs) which allows us to control the specificity and size much better.

Reworks the MDC-based chips to use the new `evolution` API instead of the deprecated one we're currently using. The new API comes with a lot of markup changes and some behavior differences. The new API also allows to remove the `GridKeyManager`, because the keyboard navigation is handled correctly by MDC.

…dle size Reworks the theme of the MDC-based chips to produce less specific and more compact CSS.

angular-automatic-lock-bot · 2022-02-11T00:02:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2021

crisbeto marked this pull request as ready for review November 9, 2021 13:50

crisbeto requested a review from mmalerba as a code owner November 9, 2021 13:50

crisbeto requested review from a team and jelbourn November 9, 2021 13:50

crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Nov 9, 2021

josephperrott removed the request for review from a team November 9, 2021 17:47

crisbeto force-pushed the mdc-chips-deprecated branch 5 times, most recently from 7ca6bb2 to 518c5b3 Compare November 12, 2021 10:27

jelbourn reviewed Nov 17, 2021

View reviewed changes

crisbeto commented Nov 17, 2021

View reviewed changes

crisbeto force-pushed the mdc-chips-deprecated branch from 518c5b3 to cf23b4c Compare November 17, 2021 08:24

jelbourn approved these changes Nov 17, 2021

View reviewed changes

jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2021

crisbeto force-pushed the mdc-chips-deprecated branch 9 times, most recently from 252953d to 809462b Compare November 24, 2021 14:30

crisbeto force-pushed the mdc-chips-deprecated branch 3 times, most recently from 82dba32 to 0f5247d Compare November 26, 2021 22:47

crisbeto force-pushed the mdc-chips-deprecated branch 8 times, most recently from 54124ef to 012edf4 Compare December 17, 2021 06:27

crisbeto force-pushed the mdc-chips-deprecated branch 12 times, most recently from 62433de to 9f25785 Compare December 25, 2021 20:04

crisbeto force-pushed the mdc-chips-deprecated branch from 1020a33 to 496e5dd Compare December 27, 2021 08:07

andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021

This was referenced Dec 30, 2021

BUG: mat-chip without mat-chip-list has no styles #9964

Closed

fix(material-experimental/mdc-chips): avoid unnecessary change detections #18043

Closed

crisbeto added 2 commits January 7, 2022 07:27

refactor(material-experimental/mdc-chips): reduce specificity and bun…

7013946

…dle size Reworks the theme of the MDC-based chips to produce less specific and more compact CSS.

This was referenced Jan 27, 2022

build(deps): bump @angular/cdk from 12.2.4 to 13.2.0 numbersprotocol/capture-cam#1197

Closed

build(deps): bump @angular/material from 12.2.4 to 13.2.0 numbersprotocol/capture-cam#1236

Closed

		static ngAcceptInputType_disabled: BooleanInput;
		static ngAcceptInputType_tabIndex: NumberInput;

Conversation

crisbeto commented Nov 9, 2021

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto commented Dec 27, 2021

Uh oh!

angular-automatic-lock-bot Bot commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants