feat(material-experimental/mdc-core): add missing color, density, typography mixins#24063
Conversation
mmalerba
added
P2
| @use './elevation'; | ||
|
|
||
|
|
||
| @mixin color($config-or-theme) { |
There was a problem hiding this comment.
Is this supposed to be the equivalent of the non-MDC core theme? If yes, it needs some more styles like the ripple and pseudo checkbox.
There was a problem hiding this comment.
currently we don't have an MDC-based ripple or pseudo checkbox. I think this should be everything for now
There was a problem hiding this comment.
Couldn't we include the non-MDC ripple here and use this mixin instead of the non-MDC one? Currently we include a bunch of unnecessary styles in the prebuilt themes, because we go through the non-MDC core mixin which contains the typographies of all non-MDC components. If you're blocked on this, it could be done in a follow-up.
There was a problem hiding this comment.
I don't think that would be a good idea, usually people include both the old mixins and new mixins while they're migrating, so if we did that we'd wind up with double the bytes
There was a problem hiding this comment.
That's basically what we've been doing with the TS code though.
mmalerba
force-pushed
the
core-theme
branch
2 times, most recently
from
cfcdb93 to
e15b582
Compare
mmalerba
added
merge: fix commit message
mmalerba
changed the title
amysorto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
No description provided.