feat(material/chips): update chip-list describedby to match input#24292
Merged
wagnermaciel merged 1 commit intoFeb 14, 2022
Conversation
7c3c16d to
292c99c
Compare
292c99c to
7dcc788
Compare
devversion
reviewed
Jan 27, 2022
Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
7dcc788 to
9b3c211
Compare
devversion
approved these changes
Jan 31, 2022
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Really another feature as part of this PR is that users are now able to add additional
accessibility descriptions (through aria-describedby) on the select, without it being accidentally overidden.
cc. @crisbeto for an additional review.
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…gular#24292) Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
This was referenced Feb 25, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates MatChipList to be consistent with MatInput, and fixes ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field, e.g.
My use-case was creating a wrapper around
mat-form-fieldto house various Mat-* formcontrol types.MatSelect could use the same update.