fix(cdk/menu): update docs to reflect current implementation and add correct role for triggers#24884
Conversation
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, mostly minor grammar nits
jelbourn
left a comment
There was a problem hiding this comment.
lgtm
One thing that occurred to me for a potential follow-up PR is documenting the CSS classes applied by the cdk menu directives
|
I added a section about CSS classes to this PR, but its pretty boring... all of the classes but one were just static always-applied classes. I guess there's a few options for what we could do with the CSS classes:
|
jelbourn
left a comment
There was a problem hiding this comment.
Repeating here from our conversation earlier for posterity:
I think the CSS classes are useful for both inheriting the directives and for when we can do directives on host elements
correct role for triggers
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.