build: fix benchpress build errors #25121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the benchpress test build errors due to an old change where the driver utilities have been moved.
devversion
added
merge safe
target: patch
crisbeto
approved these changes
Jun 21, 2022
devversion
added a commit
that referenced
this pull request
Jun 21, 2022
Fixes the benchpress test build errors due to an old change where the driver utilities have been moved. (cherry picked from commit 8b5a632)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the benchpress test build errors due to an old change
where the driver utilities have been moved.
Note that most benchpress-tests are still failing currently at runtime as it seems,
mostly because
@angular/coreimports fromrxjs/operatorswithout anexplicit extension, breaking runtime ESM resolution. We would need to consider
bundling tests in benchmark tests, similar to how we do it in the CLI or elsehwere.
(or we wait until we eventually use the new node resolution in Angular framework as well..)