Skip to content

Conversation

@crisbeto
Copy link
Member

These changes set up integration tests using Vitest so that we can catch issues like #32399.

Renames the file with common harness tests not to include `.spec.ts` since it can get picked up as a test by accident.
Updates the cross environment harness tests to account for Vitest and exclude some that don't work with a virtual DOM.
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release merge: preserve commits When the PR is merged, a rebase and merge should be performed labels Dec 18, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 18, 2025
@crisbeto crisbeto marked this pull request as ready for review December 18, 2025 12:50
@pullapprove pullapprove bot requested review from adolgachev and mmalerba December 18, 2025 12:50
Now that Vitest is the default test runner in the CLI, we need test coverage for harnesses. These changes set up an integration test that brings in the common harness tests and executes them inside a CLI app using Vitest.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 18, 2025
@crisbeto crisbeto merged commit 7b1df64 into angular:main Dec 18, 2025
27 of 29 checks passed
@crisbeto
Copy link
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants