This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Switch to ESLint #9261
Copy link
Copy link
Closed
Labels
P4: minorMinor issues. May not be fixed without community contributions.Minor issues. May not be fixed without community contributions.has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueresolution: fixedtype: build
Milestone
Description
Actual Behavior:
What is the issue? *Currently code is linted via JSHint. JSHint is dropping options related purely to code style (a lot of them have already been dropped long ago but e.g. thelaxbreakoption that we currently use is deprecated as well) so if you ever want to validate code style, you'll have to use ESLint anyway. It doesn't make sense to use two linters when one handles it all just fine.What is the expected behavior?The code is linted via ESLint.
CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:N/ADetails:N/A
Angular Versions: *
Angular Version:N/AAngular Material Version:N/A
Additional Information:
Browser Type: *N/ABrowser Version: *N/AOS: *N/AStack Traces:N/A
Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.
Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.
The migration should be easy since:
- JSCS isn't used (a lot of repos - like Angular 1.x - were using the JSHint+JSCS combo)
- There are only 3 JSHint options currently enabled
If you agree this is sth that could be done, I volunteer to prepare a PR. I've done one for AngularJS and it was way more involved than is needed in this repo. :)
Metadata
Metadata
Assignees
Labels
P4: minorMinor issues. May not be fixed without community contributions.Minor issues. May not be fixed without community contributions.has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueresolution: fixedtype: build