Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When a clickable / linkable md-list-item is provided without an aria-label, the directive creates a button/link with an aria-label. Because this element and the original inner contents are siblings, asking a screen reader to read through the document results in both the created link and the content to be read, which is awkward for screen reader users.

Issue Number:
Fixes #11582

What is the new behavior?

  • if we create an aria-label from the element's text content then mark the content as aria-hidden="true" so that screen readers don't announce/traverse the content twice
  • improve Closure types

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- if we create an `aria-label` from the element's text content
  then mark the content as `aria-hidden="true"` so that screen
  readers don't announce/traverse the content twice
- improve Closure types

Fixes #11582
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 23, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 23, 2020
@Splaktar Splaktar self-assigned this Sep 23, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. g3: sync P2: required Issues that must be fixed. type: bug pr: merge ready This PR is ready for a caretaker to review labels Sep 23, 2020
@Splaktar Splaktar requested a review from annieyw September 23, 2020 01:12
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 23, 2020
@Splaktar Splaktar merged commit 5c455d3 into master Sep 23, 2020
@Splaktar Splaktar deleted the list-item-a11y branch September 23, 2020 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list-item: default ariaLabel causes list items to be read twice

3 participants