Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • md-fab-speed-dial still triggers action when button inside of md-fab-trigger is disabled
  • md-fab buttons have box-shadow when disabled

Fixes #9467

What is the new behavior?

  • when the trigger is clicked, verify that the trigger button isn't disabled
    before toggling the open state
  • style the disabled speed dial trigger fab button using the current theme
    to support both light and dark themes
  • fix issue where the disabled background (mostly transparent)
    allowed opaque md-fab-action-items to fade through
  • disabled fab buttons now have no box-shadow which is consistent
    with Angular Material
  • fix basic usage demo to not have a black hover/focus background
    as that doesn't work at all on dark theme and was confusing in light theme
  • add test for when the click occurs on the md-icon instead of the md-button
  • remove duplicate $button-fab-width variable

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before

Screen Shot 2020-12-17 at 02 02 48

After

Screen Shot 2020-12-17 at 03 43 07

Dark theme
Screen Shot 2020-12-17 at 03 42 48

- when the trigger is clicked, verify that the trigger button isn't disabled
  before toggling the open state
- style the disabled speed dial trigger fab button using the current theme
  to support both light and dark themes
- fix issue where the disabled background (mostly transparent)
  allowed opaque `md-fab-action-item`s to fade through
- disabled fab buttons now have no `box-shadow` which is consistent
  with Angular Material
- fix basic usage demo to not have a black hover/focus background
  as that doesn't work at all on dark theme and was confusing in light theme
- add test for when the click occurs on the `md-icon` instead of the `md-button`
- remove duplicate `$button-fab-width` variable

Fixes #9467
@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 17, 2020
@Splaktar Splaktar self-assigned this Dec 17, 2020
@Splaktar Splaktar added this to the 1.2.2 milestone Dec 17, 2020
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review labels Dec 17, 2020
@Splaktar Splaktar requested a review from mmalerba December 17, 2020 08:48
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Dec 17, 2020
@Splaktar Splaktar merged commit e7dfcc1 into master Dec 17, 2020
@Splaktar Splaktar deleted the fab-speed-dial-disabled-trigger branch December 17, 2020 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fab-speed-dial: still triggers action when disabled

2 participants