This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select, input): asterisk should be always red. #9224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 024e979 added support for asterisks for the `md-select`, but also removed the red styling for the asterisk. As per specs, the asterisk should be always red, except when the input is blurred and not invalid. This commit makes the asterisk always red and makes the `md-select` asterisk consistent to the inputs.
Contributor
|
I think you mean always uses |
Contributor
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 024e979 added support for asterisks for the
md-select, but also removed the red styling for the asterisk.As per specs, the asterisk should be always red, except when the input is blurred and not invalid.
This commit makes the asterisk always red and makes the
md-selectasterisk consistent to the inputs.