feat(plugins): add postTest hook for plugins#1859
Conversation
|
@sjelin can you take a look? |
lib/plugins.js
Outdated
There was a problem hiding this comment.
Thee word "test" seems ambiguous. Is this after each it(), assert(), or describe()?
There was a problem hiding this comment.
each it() (in Jasmine) - another option would be spec. Preference?
There was a problem hiding this comment.
Also please update the comment on line 17
There was a problem hiding this comment.
We already use spec to refer to the whole file. testcase might make sense?
|
Comments addressed. |
lib/plugins.js
Outdated
There was a problem hiding this comment.
I don't think this is consistent with what you put in plugins/README.md. Shouldn't it be (pluginObj[funName] || noop).apply(this, [pluginConf].concat([].slice.call(arguments)))?
There was a problem hiding this comment.
Also maybe it would be good to test this?
spec/plugins/failing_plugin.js
Outdated
There was a problem hiding this comment.
Both blocks of this conditional are identical
There was a problem hiding this comment.
Nope, one says 'passing' and one says 'failing'
There was a problem hiding this comment.
Modified to duplicate fewer lines.
Additionally, add some tests to make sure that plugins can fail properly. Closes angular#1842
|
LGTM |
3 participants
Additionally, add some tests to make sure that plugins can fail properly.
Closes #1842