Fix CircleCI Build#4837
Conversation
|
Right, so, I have no idea why this works. I have two hypotheses:
But, hey! Circle's green again, so 🍻 all around. |
This patch fixes the continually breaking circleci build. The changes made were: - Switch to using circleci v2 syntax, as the v1 syntax will be deprecated in August. It also permits running this build locally using the `circleci` commandline tool. - Adjust timeouts on error tests to fail consistently on high-performance machines. - Correct error formatting on error tests. Fixes #4810
|
@qiyigg 🎁 for ya. Do you mind taking a look so all the queued-up PR's can rebase? |
|
@krotscheck Cool! Thanks a lot. By the way, do you find the root cause of the previous failure? |
|
@qiyigg - nothing other than supposition. What I observed is that failing builds locally tended to fail at the end of a spec, rather than at the beginning. There's a whole variety of bugs in the geckodriver project (mozilla/geckodriver#966) regarding the correct order of From what I saw in the teardown logic ( |
|
ok, thanks, merged. |
angular#4837) This patch fixes the continually breaking circleci build. The changes made were: - Switch to using circleci v2 syntax, as the v1 syntax will be deprecated in August. It also permits running this build locally using the `circleci` commandline tool. - Adjust timeouts on error tests to fail consistently on high-performance machines. - Correct error formatting on error tests.
This patch attempts to fix the continually breaking circleci build. The changes made were:
circlecicommandline tool.Fixes #4810