test: add regression tests for issue #279 (facet_wrap spacing with custom height)#288
Open
ANAMASGARD wants to merge 6 commits intomasterfrom
Open
test: add regression tests for issue #279 (facet_wrap spacing with custom height)#288ANAMASGARD wants to merge 6 commits intomasterfrom
ANAMASGARD wants to merge 6 commits intomasterfrom
Conversation
Adds comprehensive test cases to verify that facet_wrap spacing scales proportionally with custom height parameter. Tests cover: - Vertical facet layout (ncol=1) with 2x and 3x custom heights - 2x2 grid layout with 1.5x custom height - Multiple height values to verify proportionality This ensures issue #279 (excessive spacing below facets) does not regress. All tests pass (16 assertions). Refs #279
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 73.09% 73.10%
=======================================
Files 164 164
Lines 8769 8770 +1
=======================================
+ Hits 6410 6411 +1
Misses 2359 2359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
can you please post a screenshot of the proposed test? |
…facets; replace JSON-only test with browser-based regression test
- Add .style("display","block") to SVG creation in animint.js so browsers
do not add text-descender whitespace below inline SVG elements (fixes
visible gap below facet_wrap/facet_grid at any custom height).
- Replace the three animint2dir+JSON tests with a single animint2HTML test
that renders in a real browser and asserts SVG height stays proportional
(not height*num_facets) when using theme_animint(height=600) on a
facet_grid(task_id ~ .) plot with sonar/spam/vowel/waveform/zip data,
matching the ch20 examples that originally exposed the bug.
Contributor
Author
|
Collaborator
|
please fix CI |
The display:block style added to SVGs causes sapply(svg.list, xmlAttrs) to return a list instead of a matrix when SVGs have inconsistent attribute counts. Use lapply/sapply with a function to extract id attributes safely regardless of attribute structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive regression tests for issue #279 to prevent reoccurrence of excessive spacing below
facet_wrapplots when using custom height parameters.Background
Issue #279 reported that when using
facet_wrap()with a customheightparameter (different from the default 400px), excessive vertical spacing appeared below the faceted plots. The spacing did not scale proportionally with the custom height.After thorough investigation and testing with version 2025.12.4, this issue appears to be resolved. These tests ensure it doesn't regress in future updates.
Changes
test-issue-279-facet-wrap-custom-height-spacing.Rncol=1) with 2x and 3x custom heights (800, 1200)ncol=2) with 1.5x custom height (600)What the Tests Verify
The key verification is that
height_proportionvalues remain identical across all custom heights:plot.jsonheight_proportionvalues are identical regardless of custom heightTesting