Skip to content

Fix error for geom with all missing data#300

Open
tdhock wants to merge 3 commits intomasterfrom
fix-missing-err
Open

Fix error for geom with all missing data#300
tdhock wants to merge 3 commits intomasterfrom
fix-missing-err

Conversation

@tdhock
Copy link
Copy Markdown
Collaborator

@tdhock tdhock commented Feb 17, 2026

Currently the error we get for the new test case is

> animint2dir(viz)
Error in split.data.table(x, by = vars, keep.by = FALSE, drop = TRUE) (from z_animintHelpers.R#879) : 
  Argument 'by' must refer to column names in x

this error could be changed so that it helps the user fix the issue in their code.

@tdhock
Copy link
Copy Markdown
Collaborator Author

tdhock commented Feb 17, 2026

No obvious timing issues in HEAD=fix-missing-err
Comparison Plot

Generated via commit 2a4a35b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 3 seconds
Installing different package versions 1 minutes and 0 seconds
Running and plotting the test cases 2 minutes and 19 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants