Skip to content

add rosling bubbles test#303

Open
aakritixyz wants to merge 9 commits intoanimint:masterfrom
aakritixyz:add-rosling-bubbles-test
Open

add rosling bubbles test#303
aakritixyz wants to merge 9 commits intoanimint:masterfrom
aakritixyz:add-rosling-bubbles-test

Conversation

@aakritixyz
Copy link
Copy Markdown

@aakritixyz aakritixyz commented Mar 1, 2026

i'm adding test-renderer-rosling-bubbles.R to verify interactive bubble plots.

local Verification:
my previous test video didn't utilize the internal Chromote functions. I have now refactored the environment to use a Chromote backend, allowing for a post-JS rendered DOM capture.

updated Video Demo: [https://youtu.be/F5YkaAXtUbo]

@suhaani-agarwal, @tdhock please review the test logic. I have also patched the tests_init() helpers locally to support this Chromote workflow; let me know if those should be included here or in a separate PR.

@tdhock
Copy link
Copy Markdown
Collaborator

tdhock commented Mar 1, 2026

the test looks ok, but you should remove those functions.

@aakritixyz
Copy link
Copy Markdown
Author

aakritixyz commented Mar 1, 2026

@tdhock,
I have updated the PR to remove the internal helper functions and overrides as suggested.

@suhaani-agarwal
Copy link
Copy Markdown
Contributor

@suhaani-agarwal, @tdhock please review the test logic.

the test looks good and aligns with the GSoC evaluation requirements.

From my understanding, similar svg-rendering checks already exist in other test-renderer-* files, so this may not add new coverage, but it does show a clear understanding of the animint2 testing workflow.
If you’d like to explore further, you could try extending the test to validate interactive behaviours (e.g., tooltips, clickSelects, or dynamic year transitions).

@aakritixyz
Copy link
Copy Markdown
Author

@suhaani, thanks for the feedback!

i’ve updated the test to use the new parameter-based syntax for showSelected and clickSelects. i also extended it to validate interactive elements like the Play/Pause widgets and selection attributes.

@suhaani-agarwal
Copy link
Copy Markdown
Contributor

@suhaani, thanks for the feedback!

i’ve updated the test to use the new parameter-based syntax for showSelected and clickSelects. i also extended it to validate interactive elements like the Play/Pause widgets and selection attributes.

The test should typically include checking some interaction behaviour using clickID(), i.e., testing the state before and after simulating a click on an element.

@tdhock
Copy link
Copy Markdown
Collaborator

tdhock commented Mar 12, 2026

  • please try line by line execution so we can see the web browser before and after =clickID()= (this is an essential debugging skill)
  • verbally discuss in your video what you expect each line of code to do, and point to and discuss the effects that the execution has in the web browser. (so we can see that you understand the code, and you understand how to debug with chromote)

@aakritixyz
Copy link
Copy Markdown
Author

@tdhock @suhaani-agarwal,

i have updated the PR with the interactive test and verified that all 11 tests are passing. as suggested, here is the video of the line-by-line execution and debugging:

youtube video: [https://youtu.be/PX-oqmQmqaE]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants