animint.js: remove unnecessary Selectors.hasOwnProperty checks#306
animint.js: remove unnecessary Selectors.hasOwnProperty checks#306ANAMASGARD wants to merge 8 commits intomasterfrom
Conversation
Fixes #278. Replaced Selectors.hasOwnProperty(selector_name) with a simple selector_name check in draw_geom and geom_label_aligned. Removed redundant guard in update_selector. Removed Selectors.hasOwnProperty check in update_axes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 73.09% 73.08% -0.01%
==========================================
Files 164 164
Lines 8769 8766 -3
==========================================
- Hits 6410 6407 -3
Misses 2359 2359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tdhock
left a comment
There was a problem hiding this comment.
also please investigate CI failure
|
Sir @tdhock , if(selector_name) guards in Changes 1 and 2 cannot be removed safely — [selector_name] is null on initial geom rendering, so without the guards, Selectors[null].duration throws a TypeError and breaks all 149 JS tests. |
|
ok i see now " [selector_name] is null on initial geom rendering" why and when does that happen? |
…e only
Replace bare if(selector_name) guards in geom_label_aligned and draw_geom
with if(selector_name && Selectors[selector_name].hasOwnProperty("duration"))
to match the same pattern already used in update_axes (Change 3).
Fixes #278
I confirm I have not used any AI code generation tools for this PR.