Change ggplot legend theme back to default#69
Conversation
|
@tdhock Hi, I just changed the default size back in theme-default.r . It shall only be 16px for the legend text in animint/html. |
| .style("fill", function(d){return d["textcolour"]||1;}) | ||
| .style("text-anchor", "middle") | ||
| .attr("font-size", function(d){return d["textsize"]||16;}) | ||
| .attr("font-size", function(d){return d["textsize"]||1;}) |
There was a problem hiding this comment.
please use consistent indentation
|
I don't think the text wrapping is a problem (that depends on the size of the browser window). |
| .style("text-anchor", "middle") | ||
| .attr("font-size", function(d){return d["textsize"]||1;}) | ||
| .attr("font-size", function(d){return d["textsize"]||1;}) | ||
| .text("a"); |
There was a problem hiding this comment.
indentation still does not match ...
There was a problem hiding this comment.
Sorry, it must be something wrong with my vscode. I just fixed some of the other code I wrote, is that ok?
|
hi @Faye-yufan can you please merge this PR? |
2 participants
According to the code review in PR #66 , when using static ggplot without html rendering, the legend text size would become too big.