Skip to content

Porting the 57th visualization gallery from the NAU rcdata server#10

Closed
nhintruong wants to merge 5 commits intogh-pagesfrom
Porting-visualization-gallery
Closed

Porting the 57th visualization gallery from the NAU rcdata server#10
nhintruong wants to merge 5 commits intogh-pagesfrom
Porting-visualization-gallery

Conversation

@nhintruong
Copy link
Copy Markdown
Contributor

I am updating the 57th data viz from the NAU rcdata server to GitHub Pages animint gallery

Here is the preview: https://nhintruong.github.io/breakpoints/

@nhintruong nhintruong requested review from Faye-yufan and tdhock July 10, 2024 09:14
@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Jul 10, 2024

thanks! as we discussed earlier, can you please close this pr and re-make one like #9 from your fork (nhintruong/gallery branch gh-pages), with a link to your fork of the updated gallery?
The existing documentation for this process is here https://github.com/animint/gallery?tab=readme-ov-file#add-your-data-viz-to-the-gallery
in particular 7. Make sure your pull request description has a link to the rendered version of your fork of the gallery, such as https://your_github_username.github.io/gallery/. That way, reviewers can quickly preview what the new gallery would look like after merging the pull request.
do you understand that? if not, can you please suggest clarifications?

@nhintruong
Copy link
Copy Markdown
Contributor Author

thanks! as we discussed earlier, can you please close this pr and re-make one like #9 from your fork (nhintruong/gallery branch gh-pages), with a link to your fork of the updated gallery? The existing documentation for this process is here https://github.com/animint/gallery?tab=readme-ov-file#add-your-data-viz-to-the-gallery in particular 7. Make sure your pull request description has a link to the rendered version of your fork of the gallery, such as https://your_github_username.github.io/gallery/. That way, reviewers can quickly preview what the new gallery would look like after merging the pull request. do you understand that? if not, can you please suggest clarifications?

Thank you for your guidance. I created a new PR here following your comment #12

@nhintruong nhintruong closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants