Skip to content

Fix Issue #39: Add ChIP-seq Large Margin Visualization to Gallery#46

Merged
ANAMASGARD merged 7 commits intoanimint:gh-pagesfrom
ANAMASGARD:gh-pages
Mar 19, 2026
Merged

Fix Issue #39: Add ChIP-seq Large Margin Visualization to Gallery#46
ANAMASGARD merged 7 commits intoanimint:gh-pagesfrom
ANAMASGARD:gh-pages

Conversation

@ANAMASGARD
Copy link
Copy Markdown
Contributor

@ANAMASGARD ANAMASGARD commented Dec 8, 2025

Fixes #39
Fixes #35

This PR adds the ChIP-seq large margin visualization AND fixes the title mismatch issue.

1. ChIP-seq Large Margin Viz (Issue #39)

Source Code

Deployed Viz

Gallery Update

  • Added ANAMASGARD/chip-seq-large-margin to repos.txt
  • Generated screenshot: repos/ANAMASGARD/chip-seq-large-margin.png

2. Gallery Title Fix (Issue #35)

Fixed title mismatch for climate visualization:

  • Before: "Climate change sensor stations"
  • After: "CRUTEM4 Temperature Sensor Stations"

The title now matches what's in the source code. Fixed by clearing cached metadata and re-running update_gallery().

Preview

https://ANAMASGARD.github.io/gallery/

@tdhock This is ready for review!

@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Feb 10, 2026

there are two issues.
old viz below has widerect which is easier to select than the segment you used.
image
your viz below has blue text too small to read.
image
please fix. (use widerect, and increase text size)

also why are there so many diff lines in meta.csv?
There should be only 2 because you only modified two gallery entries, right?

Copy link
Copy Markdown
Contributor

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix

- Fixed climate viz title to match source code (Issue animint#35)
- Added chip-seq large margin entry (Issue animint#39)
- Regenerated index.html from the updated meta.csv
@ANAMASGARD
Copy link
Copy Markdown
Contributor Author

ANAMASGARD commented Feb 11, 2026

Sir @tdhock,
I’ve addressed your feedback:-

  • Made the chip‑seq selection areas wide/easy to click (like widerect).
  • Increased the blue explanatory text and sample label sizes so they are readable.
Screenshot From 2026-02-11 14-16-15

PLease give your feedback

@ANAMASGARD ANAMASGARD requested a review from tdhock February 11, 2026 09:44
@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Feb 13, 2026

rect looks good but blue text still looks too small. it should be about the same size as surrounding text.

@ANAMASGARD
Copy link
Copy Markdown
Contributor Author

Sir @tdhock I have increased the size of both the blue text and the black made the size=8 for clear visibility.

Screenshot From 2026-02-15 21-09-43

@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Feb 27, 2026

the text is still too small, can you please increase so that it is same as surrounding text size?

@ANAMASGARD
Copy link
Copy Markdown
Contributor Author

Sir @tdhock
Increase the size made it 12 please tell , it is readable without zoom .

image

@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Mar 5, 2026

on my screen constant and margin are unreadable (go off of right side of screen). please revise so that they are readable in plotting area.

also the original has smooth transitions: when you change peaks, segment in regression plot updates with a smooth transition. can you please add that?

your viz below only has one peaks selector
image

original below has a peaks selector for each sample
image

2 more problems with top plot:
image

  • yours only displays blue peaks for the selected sample (original displays blue peaks for all samples)
  • sample names in panel titles overlap

can you please fix?

@ANAMASGARD
Copy link
Copy Markdown
Contributor Author

Sir @tdhock, I pushed another update to the ChIP-seq viz :-

  • Moved “large margin / small margin / constant” text fully inside the regression panel (no cutoff)
  • Added smooth transitions when changing peaks
  • Peaks selection is now per-sample (4 selectors)
  • Top plot now shows blue peaks for all samples (not only the selected one)
  • Fixed the overlapping sample strip titles
    Updated version: https://ANAMASGARD.github.io/chip-seq-large-margin/
    I also updated the gallery screenshot in this PR.
  • But McGill0002 sample.ids and blue text they still look small should I increase the size or not ??

Sir review and give your feedback .

@tdhock
Copy link
Copy Markdown
Contributor

tdhock commented Mar 10, 2026

please compare with original. yours looks like this, too many panels
image

@ANAMASGARD ANAMASGARD merged commit 6c56896 into animint:gh-pages Mar 19, 2026
@ANAMASGARD
Copy link
Copy Markdown
Contributor Author

Sir @tdhock, I want to explain what happened clearly and ask your preferred next step.

I made a mistake while trying to update the ChIP-seq screenshot/workflow.
I pushed directly to upstream gh-pages, and that caused the PR state to change/merge flow unexpectedly.
Then I reverted those merged changes in commit 5bb862a (Revert PR #46), so the current branch no longer contains the PR #46 content.

Sorry please tell me what should I do now ????

@suhaani-agarwal
Copy link
Copy Markdown
Contributor

suhaani-agarwal commented Mar 20, 2026

@ANAMASGARD please do not push directly to gh-pages going forward just keep that in mind.
It’s good that you’ve reverted the changes. Please open two separate PRs to address the individual issues (#39 and #35), and please ensure that all previously requested changes are fully incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chip-seq large margin data viz Mismatch between source titles and gallery titles

3 participants