JS API: Add Remaining Card Properties

[david-allison]

Purpose / Description

Properties weren't available and were requested. Added them all: factor, id, mod, nid, type, did, left, odid, odue

Fixes

Fixes #5587

Approach

Provide the properties

How Has This Been Tested?

Untested

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code

[david-allison]

@Anthropos888 @infinyte7 Does the format of these properties seem sensible to you guys?

[david-allison]

Potential discussion points:

• Naming of created: Created/CreationTime
• Is sending a unix timstamp the best way?
• Should the ease be a double (2.5), or the database value of 2500? Do we want to call it factor or ease

[Arthur-Milchior]

I do like the idea. Is there any reason why you add access to those values, and not all values from the database simultaneously ?

[krmanik]

The value stored in Ankidroid should be passed and details about changing it, should be provided in wiki. It will help in designing card with exact numbers. For example. eta is passed, not eta*60. But if it needs to changed then also okay.

[mikehardy]

javascript can consume unix epoch timestamps directly in new Date(millisSince1970) so that's good

javascript only has a number numeric type, and it is a double. Number should be sent to javascript as doubles if possible, or if not they should probably be strings so that they are not modified in anyway and javascript can figure out how to handle them, as @infinyte7 mentions (via parseInt(number, radix) or similar

[mikehardy]

comments on naming and datatypes

[david-allison]

Other methods in the class are returning long/int.

I'll return these until we decide to move to String/double, as these will all need to be tested at once.

[david-allison]

Noting: ankiGetCardInterval should be ankiGetCardIvl

[david-allison]

Pushed - added all properties as requested by Arthur. Names and data types now match the AnkiDroid codebase

[mikehardy]

fantastic