Conversation
Add an area that can use one-sided window allocation to allocate memory. The interface is limited by the required arguments on communicators, requiring us to keep track of the created windows internally to be able to cleanly destroy them. Could probably also design a DMA to use puts and gets and fence, even if that would be a bit strange in terms of API, since they don't really match the "stream of copy request" model.
MPICC doesn't work for the entire aml, and changing the CC for just a file is difficult, so let's put all mpi logic in subdirs, and create a libaml-mpi.so for the mpi support.
rpereira-dev
previously approved these changes
Sep 16, 2025
rpereira-dev
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an area that can use one-sided window allocation to allocate memory. The interface is limited by the required arguments on communicators, requiring us to keep track of the created windows internally to be able to cleanly destroy them.
Could probably also design a DMA to use puts and gets and fence, even if that would be a bit strange in terms of API, since they don't really match the "stream of copy request" model.