[feature] Improve event management for batches#97
Merged
Conversation
Replace event message with a list of timeseries, but don't change the client/server APIs to take advantage of it. Working checks regardless.
Simplify the eventbase to retrieve timeseries and pass them back to the control loop. We should update the ticking function to remove old events.
perarnau
changed the title
This was referenced Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for batches of events in the networking layer, while simplifying the interface to control loops.
The goal is to have the timeserie type contain implementations of the several type of event analysis we've tried as control inputs.
To be followed by another PR for event stats.