Merged
Conversation
added 16 commits
January 17, 2021 00:40
…ging to productive)
Owner
|
Puh. I didn't get that you opened this PR to my repo. I cdon't understand it yet, but you must keep in mind that the windows build depends on the content of the improve_win_ci branch |
Author
|
does the request point to the newest commit of my branch(732f984)? |
Owner
|
I think so. Can you merge the content of my repo (enableWinBuild branch) in a branch on your repo, and merge the new windows installer (improve_win_ci branch on corrados repo)? This might allow you to have a working build for Windows and android |
Owner
|
I am 99% sure that this will work once jamulussoftware#841 is merged |
Owner
|
Can you merge corrados/master into your branch now? |
Owner
|
Let's have a look at it. I will merge it into a branch which is up to date with the current corrados master |
Owner
|
I think it works now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do you understand whats wrong here?