Open
Conversation
|
Hi Anna PR Feedback ReportStudent: Anna What You Did Well (Hits)The pull request exists and is accessible. The branch name is correctly 'assignment-1'. Question 1: Correctly identified the response variable type as 'int64' and its levels as '[0 1 2]'. Question 2: The output shows evidence of data splitting and standardization, although the full code for verification is not directly visible in the output. Question 5: Cross-validation was used as part of GridSearchCV. Question 7: Accuracy was calculated on the test data. Overall AssessmentThe submission demonstrates an understanding of the assignment's requirements and attempts to address all questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
This is to complete the 1st assignment of the LCR module
What did you learn from the changes you have made?
The best value for n-neighbors can be 1 if classes are well-separated, there's low noise in the data, the dataset is small and clean
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I added some extra code to visualize the best n_neighbors results
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
n/a
How were these changes tested?
I ran the code to ensure it works as expected
A reference to a related issue in your repository (if applicable)
n/a
Checklist