Skip to content

To submit LCR asssignment 1#1

Open
anna-utm wants to merge 1 commit intomainfrom
assignment-1
Open

To submit LCR asssignment 1#1
anna-utm wants to merge 1 commit intomainfrom
assignment-1

Conversation

@anna-utm
Copy link
Copy Markdown
Owner

@anna-utm anna-utm commented Sep 5, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

This is to complete the 1st assignment of the LCR module

What did you learn from the changes you have made?

The best value for n-neighbors can be 1 if classes are well-separated, there's low noise in the data, the dataset is small and clean

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I added some extra code to visualize the best n_neighbors results

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

n/a

How were these changes tested?

I ran the code to ensure it works as expected

A reference to a related issue in your repository (if applicable)

n/a

Checklist

  • I can confirm that my changes are working as intended

@efantinatti
Copy link
Copy Markdown

Hi Anna

PR Feedback Report

Student: Anna
GitHub Username: @anna-utm
PR Number: 1
Branch: assignment-1
Status: COMPLETE
PR URL: #1

What You Did Well (Hits)

The pull request exists and is accessible. The branch name is correctly 'assignment-1'. Question 1: Correctly identified the response variable type as 'int64' and its levels as '[0 1 2]'. Question 2: The output shows evidence of data splitting and standardization, although the full code for verification is not directly visible in the output. Question 5: Cross-validation was used as part of GridSearchCV. Question 7: Accuracy was calculated on the test data.

Overall Assessment

The submission demonstrates an understanding of the assignment's requirements and attempts to address all questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants