Log a warning if the token is likely bad#34
Merged
Michel Edkrantz (MichelEdkrantz) merged 2 commits intomasterfrom Aug 15, 2025
Merged
Log a warning if the token is likely bad#34Michel Edkrantz (MichelEdkrantz) merged 2 commits intomasterfrom
Michel Edkrantz (MichelEdkrantz) merged 2 commits intomasterfrom
Conversation
Peter Newman (petern-annotell)
requested a review
from Michel Edkrantz (MichelEdkrantz)
as a code owner
Michel Edkrantz (MichelEdkrantz)
requested changes
Apr 28, 2025
Peter Newman (petern-annotell)
requested a review
from Michel Edkrantz (MichelEdkrantz)
Michel Edkrantz (MichelEdkrantz)
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a support ping to team order.
Sometimes logging a refreshed auth token fails because the response doesn't contain the expiry time. Since this is only logging, it's a shame to get an error here. This attempts to turn the error into a warning of problems to come. Auth will still likely not have worked.
Users are seeing this now with KIO 2.4.0 against prod, we don't know why. Seems the auth-api is happily handing out tokens to the user in question. But this might shed some light on what the response contains.
Edit: the response contains 429 rate limit exceeded errors. Attempt to surface those here: #35