Fixes type annotations on the sessions#54
Merged
Michel Edkrantz (MichelEdkrantz) merged 1 commit intomasterfrom Feb 19, 2026
Merged
Fixes type annotations on the sessions#54Michel Edkrantz (MichelEdkrantz) merged 1 commit intomasterfrom
Michel Edkrantz (MichelEdkrantz) merged 1 commit intomasterfrom
Conversation
Daniel Willim (kognic-willim)
requested a review
from Michel Edkrantz (MichelEdkrantz)
as a code owner
Michel Edkrantz (MichelEdkrantz)
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async session does not pickup the correct type annotations
The
AsyncOAuth2Clientitself inherits from theAsyncClientand the other functions fromAsyncOAuth2Clientare not used. This is also how we do it in with the non async client