Refactor cred mgmt#61
Merged
Michel Edkrantz (MichelEdkrantz) merged 4 commits intomasterfrom Feb 23, 2026
Merged
Conversation
… mock to test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiCredentialsdataclass into its owncredentials.pymoduleget_credentials_from_system()returning a fullApiCredentials(orNone), replacing the old tuple-returning logicresolve_any_credentials()to cleanly handle all supported auth input types (tuple,ApiCredentials, dict, file path, keyring URI)resolve_credentials()to use the new helpers; fix bug where explicitclient_id/client_secretarguments were ignored and fell through to system credential lookupexpanduser().resolve()before reading_anonymous_credentials()helpernamefield toApiCredentialswith default valuetest_no_credentials_returns_noneto prevent real keyring credentials leaking into the test