Skip to content

Add branch protection rules to require CI checks to pass before merging #9613

@MBanucu

Description

@MBanucu

Problem

Currently, there are no branch protection rules on the repository. This allows PRs to be merged even when CI checks fail, as demonstrated by PR #9238, which had failing nix-desktop builds but was still merged. This can lead to broken builds being deployed.

Proposed Solution

Add branch protection rules for the dev branch (and others as needed) to require the following CI checks to pass:

  • nix-desktop (builds the Nix flake on multiple platforms)
  • test
  • typecheck
  • Any other critical checks

Benefits

  • Ensures code quality and prevents merging broken changes.
  • Catches issues like the Bun version mismatch early.
  • Follows best practices for CI/CD.

Related Issues/PRs

This would prevent future issues and improve the reliability of the codebase.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions