fix(opencode): merge authentication methods from all matching plugins#10065
Open
thoreinstein wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): merge authentication methods from all matching plugins#10065thoreinstein wants to merge 1 commit intoanomalyco:devfrom
thoreinstein wants to merge 1 commit intoanomalyco:devfrom
Conversation
Previously, the auth command used `.find()` to locate the first plugin matching a provider. This allowed plugins loaded earlier to "shadow" others (e.g., `opencode-websearch-cited` shadowing `opencode-gemini-auth`), preventing OAuth options from being displayed. This change: - Updates `auth login` to collect all matching plugins and merge their methods. - Adds robust type checking and error handling to the plugin loader to prevent malformed plugins from breaking the system. Fixes anomalyco#10063
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #6260: fix: merge auth methods from multiple plugins for the same provider
The current PR (10065) and PR #6260 both tackle the problem of plugin shadowing by collecting authentication methods from all matching plugins instead of stopping at the first match. |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the auth command used
.find()to locate the first plugin matching a provider. This allowed plugins loaded earlier to "shadow" others (e.g.,opencode-websearch-citedshadowingopencode-gemini-auth), preventing OAuth options from being displayed.This change:
auth loginto collect all matching plugins and merge their methods.Fixes #10063
How did you verify your code works?
bun dev auth login