feat: bugfix to snapshot pruning and allow snapshot config to accept positive integer for retention lifespan in days (resolves #10626, #10782, #6845, #3182, #10532)#10628
Closed
ariane-emory wants to merge 0 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
4 times, most recently
from
f1ae801 to
08fa7f7
Compare
ariane-emory
force-pushed
the
feat/configurable-snapshot-lifespan
branch
2 times, most recently
from
44d80d1 to
c29f3e6
Compare
ariane-emory
force-pushed
the
feat/configurable-snapshot-lifespan
branch
from
7b5f260 to
dd1624e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR corrects a bug in the current implementation where old snapshots' directories are not being properly pruned: currently only individual objects inside the snapshot are pruned after their exceeds the retention time limit, not the folders in their entirety. This PR ensures that expired snapshots' folders are correctly pruned.
Additionally, this PR allows for the value of the
snapshotsetting inopencode.jsonto be either a boolean value (as is the case currently) or a positive integer controlling how many days snapshots should be retained for. A value of 0 is treated equivelantly to"snapshot": false, disabling the snapshots feature entirely.This feature will allow users to better control how much space is ultimately used by OpenCode for the storage of snapshots.
Tests are included to make sure that valid configuration values for
snapshotare parsed correctly.Resolves #10626.
Resolves #10782.
Resolves #6845.
Resolves #3182.
Resolves #10532.
This feature should also provide a means to mitigate numerous other issues involving complaints about a huge snapshot folder consuming excessive disk space.
How did you verify your code works?
Manual testing plus
bun testandbun typecheck: no new failing tests introduced relative to the current HEAD of dev. Dogfooding: I have been using this in my own fork since this PR's time of submission and it does appear to be working exactly as it was designed to. Yay!