fix(patch): parse Windows drive-letter paths#10808
Open
ilepn wants to merge 3 commits intoanomalyco:devfrom
Open
fix(patch): parse Windows drive-letter paths#10808ilepn wants to merge 3 commits intoanomalyco:devfrom
ilepn wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Author
|
Note: I ran a headless ApplyPatchTool check with Windows path variants. Drive-letter, UNC (\localhost\c$...), and ADS paths worked end-to-end. The ?\ long-path form still fails later in ApplyPatchTool due to path.resolve normalization (separate issue). The ?\ parser test is kept to ensure header parsing preserves the path string. |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
|
I independently arrived at the same fix on Windows (see #13582) and can confirm this resolves the issue. Tested on Windows 11 — patches with absolute drive-letter paths like Happy to close my duplicate PR if this one gets merged. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Windows, apply_patch headers like "*** Update File: D:..." were truncated at the drive letter because the patch header parser split on ':'; this produced paths like 'D' and caused apply_patch to fail.
Fixes #10360.
What
Test