fix(tui): don't clear selection when OPENCODE_EXPERIMENTAL_DISABLE_COPY_ON_SELECT is enabled#10897
Draft
ariane-emory wants to merge 29 commits intoanomalyco:devfrom
Draft
fix(tui): don't clear selection when OPENCODE_EXPERIMENTAL_DISABLE_COPY_ON_SELECT is enabled#10897ariane-emory wants to merge 29 commits intoanomalyco:devfrom
ariane-emory wants to merge 29 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
…ABLE_COPY_ON_SELECT is set
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
4 times, most recently
from
f1ae801 to
08fa7f7
Compare
Resolved conflict in packages/opencode/src/cli/cmd/tui/app.tsx: - Accepted dev branch's refactored copy-on-select logic - Uses new Selection.copy() helper function - Added right-click support for copying when selection is active
5 tasks
github-actions
bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
R44VC0RP
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #10490. (or at least seriously mitigates the secondary issue described in the its comments)
i### What does this PR do?
When Opencode is started with the
OPENCODE_EXPERIMENTAL_DISABLE_COPY_ON_SELECTflag set, text will not be immediately unselected after being selected.How did you verify your code works?
Manual A/B testing,
bun test,bun typecheck