fix(tui): resolve EditBuffer destroyed error in dialog-select#11093
Closed
njyeung wants to merge 2 commits intoanomalyco:devfrom
Closed
fix(tui): resolve EditBuffer destroyed error in dialog-select#11093njyeung wants to merge 2 commits intoanomalyco:devfrom
njyeung wants to merge 2 commits intoanomalyco:devfrom
Conversation
Fixes race condition where input focus was called on a potentially stale reference before the EditBuffer was fully initialized. Changed from setTimeout with closure variable to queueMicrotask with direct parameter reference to ensure the correct input instance is focused. Verified by testing provider connection flow (Moonshot AI) which previously crashed with "EditBuffer is destroyed" error.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
4 times, most recently
from
f1ae801 to
08fa7f7
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10926
Fixes race condition where input focus was called on a potentially stale reference before the EditBuffer was fully initialized.
What does this PR do?
The problem stems from a race condition where
input.focus()was being called on a potationally stale closure variable before EditBuffer was fully initialized. Changing toqueueMicrotaskinstead ofsetTimeoutfor more immediate execution andr.focus()instead ofinput.focus()to ensure we're focusing the instance that was just created.How did you verify your code works?
Verified by testing provider connection flow (Moonshot AI) which previously crashed with "EditBuffer is destroyed" error.