feat(tui): add session delete command with confirmation dialog#11684
Open
frouo wants to merge 5 commits intoanomalyco:devfrom
Open
feat(tui): add session delete command with confirmation dialog#11684frouo wants to merge 5 commits intoanomalyco:devfrom
frouo wants to merge 5 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, I found one potentially related PR: PR #6732 - feat: add delete session button to session header This PR is related because it also addresses session deletion functionality. However, PR #6732 adds a delete button to the session header UI, while the current PR #11684 adds a You should verify if one of these PRs has already been merged or if they should be consolidated into a single approach. |
frouo
force-pushed
the
feature/add-a-delete-command-to-delete-the-current-session-#8677
branch
from
9d24a77 to
5d319a4
Compare
Without preventDefault or stopPropagation, the return key event continues propagating after the dialog closes. When navigating to a new screen with a prompt (e.g., after deleting a session via /delete command), the stale event inserts an unwanted newline, causing the cursor to start on line 2 instead of line 1. Tested independently: both preventDefault() and stopPropagation() fix the issue on their own. Claude Sonnet 4.5 recommands adding both as the safest approach and aligns with the existing pattern used in DialogSelect.
frouo
force-pushed
the
feature/add-a-delete-command-to-delete-the-current-session-#8677
branch
from
ca4781c to
bfa06cb
Compare
…rrent-session-#8677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a
/deletecommand to delete the current sessionCloses #8677
Demo video : #8677 (comment).
Note: The 3rd commit fixes a routing bug shown at the end of the demo video where an extra newline appeared when returning to the home screen after deletion.
How did you verify your code works?
I tested it by running
bun dev.