fix: Use different OAuth App ID for GitHub Enterprise#11990
fix: Use different OAuth App ID for GitHub Enterprise#11990jtyr wants to merge 5 commits intoanomalyco:devfrom
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #6974 - "fix(tui): enable GitHub Copilot Enterprise authentication in /connect…" Why it might be related: This PR also addresses GitHub Enterprise authentication. Since PR #11990 is specifically about fixing the OAuth App ID for GitHub Enterprise login, and PR #6974 is about enabling GitHub Copilot Enterprise authentication, they may be working on the same underlying authentication issue or related features. I'd recommend checking PR #6974 to see if it's already addressing the same issue (#3936) or if the approaches overlap. |
|
@rekram1-node, could you please review this PR when you get a chance? I have tested it and it is working. |
|
👍 testet it (did my own opencode bun build) - that patch worked for me based on 1.1.53 with a79cca1 cherry-picked🥇 |
I don't think PR #6974 is necessary for copilot oauth ghe login, I've build based on these commits and I was able to do a fresh ghe login: |
|
@MarkSchmitt PR #6974 adds support for connecting Github Enterprise from the TUI using the /connect command. Right now, /connect only works with github.com and does not provide an option to connect to GitHub Enterprise so that PR is unrelated with this PR |
|
Unfortunately we need to setup an actual enterprise app on github to comply w/ rules. Let me see what id u are using here |
GitHub Copilot CLI OAuth App ID |
|
Yeah they dont want us to do that unfortunately, waiting for github app process to complete |
|
The OpenCode OAuth has been approved for GitHub Enterprise so this workaround is not needed anymore. |
What does this PR do?
This PR fixes #3936 by using a different OAuth App ID for GitHub Enterprise login process. The reasoning and more details are described in my comment in that issue.
How did you verify your code works?
I was able to login to our ghe.com instance like that and then use Copilot via OpenCode.