feat(app): embed web ui in binary#12829
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
a18c3ed to
fb3dd29
Compare
|
Any news on this PR ? I'm interested in this feature |
fb3dd29 to
95b2972
Compare
I will ping maintainers on this, they said they were interested in doing this themselves |
|
Since I'm also very interested in this PR I've tested these changes in a fully air-gapped Docker container ( Against v1.2.15 (before this PR), two tests fail:
Against this PR branch, both pass.
We also verified that all JS/CSS/font assets referenced by |
95b2972 to
65c92b1
Compare
|
Honestly, this should be the default and the way it is done now with the CDN should get a disclaimer and an explanation for when and how that is useful? It just destroyed quite some trust towards this project realizing that the team went an extra mile to separate the webUI from the server, only to take away control from the user on what webUI code they are running. |
|
had to make some changes to this PR and had to move it to a new branch so closing this for now |
no worries, nice to see this getting shipped at last, I almost gave up on this lol |
|
could someone link the branch where this feature was moved pls? |
|
@farkas93 As far as I understood #19217 (comment), this is now part of 1.3.3 |
What does this PR do?
While building opencode binary, also build the web ui and bundle it with the binary to keep the web ui in sync
also very useful in air gapped systems
extra flag to disable and use hosted version if needed
How did you verify your code works?
Tested web/serve with opencode and checked headers
fixes #8549
fixes #6352
fixes #12445
fixes #12083
and countless related issues