fix(opencode): set session status before async operations#12922
Open
Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): set session status before async operations#12922Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Conversation
Set SessionStatus to busy before fire-and-forget in prompt_async so clients see the correct status immediately. Also add a null check for Agent.get() in createUserMessage to prevent crashes when an invalid agent name is provided. Closes anomalyco#12860
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionStatustobusybefore the fire-and-forgetSessionPrompt.prompt()call in theprompt_asyncroute, so clients see the correct status immediatelyidleif the async prompt failsAgent.get()increateUserMessageto throw a clear error when an invalid agent name is providedCloses #12860
Test plan
prompt_asyncand verifySessionStatusisbusyimmediately after the call returnsidle