fix(tui): use theme colors for text selection#13352
Open
akronb wants to merge 2 commits intoanomalyco:devfrom
Open
fix(tui): use theme colors for text selection#13352akronb wants to merge 2 commits intoanomalyco:devfrom
akronb wants to merge 2 commits intoanomalyco:devfrom
Conversation
|
I tested this out locally, much better experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5295
Fixes #6630
Fixes unreadable text selection highlights in light themes by introducing theme-aware selection tokens.
What’s changed
selectionBgandselectionFgtouseTheme. The highlight background is now a subtle tint of the primary color, foreground usestheme.text.How did you verify your code works?
fix_highlighting.mp4