fix(opencode): preserve custom tool arg descriptions in LLM prompts#13417
Open
yinghaosang wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): preserve custom tool arg descriptions in LLM prompts#13417yinghaosang wants to merge 1 commit intoanomalyco:devfrom
yinghaosang wants to merge 1 commit intoanomalyco:devfrom
Conversation
Use zodToJsonSchema() instead of z.toJSONSchema() for converting custom tool parameter schemas. The built-in z.toJSONSchema() drops .describe() metadata from dynamically imported Zod schemas, so LLMs never see the argument descriptions users define on their custom tools. Closes anomalyco#4357
6 tasks
This was referenced Mar 4, 2026
|
Heads up — switching from The actual root cause for plugin tools losing descriptions is cross-Zod-instance metadata loss (Zod v4 stores |
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4357
Custom tool
.describe()metadata on args wasn't making it into the prompts sent to providers.prompt.tswas usingz.toJSONSchema()to convert Zod schemas, but that method drops descriptions from dynamically imported schemas.experimental.tsalready useszodToJsonSchema()fromzod-to-json-schemawhich handles this correctly — this just makesprompt.tsconsistent.How did you verify your code works?
bun typecheckpasses. Confirmed thez.toJSONSchemacall is gone and replaced withzodToJsonSchemawhich already works correctly inexperimental.ts.