Skip to content

fix(test): move timeout config to CLI flag #13494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
R44VC0RP merged 1 commit into from
Feb 13, 2026
Merged

fix(test): move timeout config to CLI flag #13494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/opencode/bunfig.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ preload = ["@opentui/solid/preload"]

[test]
preload = ["./test/preload.ts"]
timeout = 30000 # 30 seconds - allow time for package installation
# timeout is not actually parsed from bunfig.toml (see src/bunfig.zig in oven-sh/bun)
# using --timeout in package.json scripts instead
# https://github.com/oven-sh/bun/issues/7789
Comment on lines +5 to +7
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says “timeout is not actually parsed from bunfig.toml”, but it’s specifically the [test].timeout field that Bun currently ignores (while [test].preload is still used). Consider rewording to avoid implying Bun ignores the whole bunfig file, and (optionally) mention the Bun version(s) affected for future readers.

Suggested change
# timeout is not actually parsed from bunfig.toml (see src/bunfig.zig in oven-sh/bun)
# using --timeout in package.json scripts instead
# https://github.com/oven-sh/bun/issues/7789
# Note: [test].timeout is not currently parsed from bunfig.toml (see src/bunfig.zig in oven-sh/bun),
# so we use --timeout in package.json scripts instead. [test].preload is still honored.
# See: https://github.com/oven-sh/bun/issues/7789

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion packages/opencode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"private": true,
"scripts": {
"typecheck": "tsgo --noEmit",
"test": "bun test",
"test": "bun test --timeout 30000",
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the test script passes --timeout 30000. This package also runs tests via bun test --coverage in the lint script, which will still use Bun’s default 5000ms timeout and can fail for tests that install dependencies (e.g. Config.waitForDependencies() in test/config/config.test.ts). Consider adding the same --timeout 30000 flag there (or factoring a shared base test command) to keep test execution consistent.

Copilot uses AI. Check for mistakes.
"build": "bun run script/build.ts",
"dev": "bun run --conditions=browser ./src/index.ts",
"random": "echo 'Random script updated at $(date)' && echo 'Change queued successfully' && echo 'Another change made' && echo 'Yet another change' && echo 'One more change' && echo 'Final change' && echo 'Another final change' && echo 'Yet another final change'",
Expand Down
Loading