feat(ui): add abyss theme (Web/App)#13555
feat(ui): add abyss theme (Web/App)#13555burgercrisis wants to merge 21 commits intoanomalyco:devfrom
Conversation
There was a problem hiding this comment.
All the current themes contain ~130 lines of code. Your suggested theme contains 750. Do you know why is that?
There was a problem hiding this comment.
Actually, I was wrong - OC-1 theme contains ~540 LOC. I'm wondering why, does not seem to be the standard
There was a problem hiding this comment.
And Tokyo night has ~150 LOC. It is clear that these themes have more color keys than most of the others. Probably should be refactored, i think all themes should have the same number of color keys
There was a problem hiding this comment.
I did an inspection just now; I will refactor it;
Basically, I was ensuring full WCAG compliance + classic abyss main colors; in my WCAG checking process, I was checking every apparent UI pair, but missed something that led to an expansion of tokens;
on inspection it seems like some past existing mappings were actually deleted from the actual UI at some point; so thats why OC-1 has 540 and mine has even more, but some mappings for OC-1 actually don't go anywhere (at minimum text-on-interactive-base, text-on-interactive-weak, still need to actually confirm the rest of the suspects), and I didn't catch things like that when I built my WCAG compliance checking system so I inherited a lot of extra WCAG checks. Since I'll be fixing my Abyss theme, I could try fixing the unmapped items from OC-1 as well for a separate pr since it wouldn't add much work doing both
There was a problem hiding this comment.
@alexyaroshuk I've carefully looked over the theme system, cleaned up placeholder/dead tokens, and removed overrides that could be generated from seeds and reduced line count to 105 while maintaining style. I may have a push later to remove deadcode tokens as well and/or reduce token count in other themes. Cleaned commit here
There was a problem hiding this comment.
@burgercrisis looks good, i checked out your pr - but it seems you hadn't merged latest upstream. make sure you do that, and resolve existing conflicts
There was a problem hiding this comment.
@alexyaroshuk Woops, just merged the latest origin/dev
There was a problem hiding this comment.
Since the only "conflict" was that oc-2 and abyss were added in the same spot in default-themes, I have to assume the failed checks are from the workflow updates that were just done in the dev branch
There was a problem hiding this comment.
@alexyaroshuk merged the stable merge in, no more conflicts or failed tests
|
Could this get a look? @adamdotdevin |
Removed unused theme imports and exports for carbonfox, gruvbox, and aura.
2 participants
Closes #13554
Summary
Add Abyss theme for Desktop/Web based on the existing CLI palette w/ full WCAG compliance
Register the theme in the default theme list
Screenshots
dark
light
How I tested
Switched theme to abyss in both light and dark modes
Checked visually and adjusted with WCAG compliance app, reiterated, aligned light mode stylistically