fix: use parentID matching instead of ID ordering for prompt loop exit and message rendering by MakonnenMak · Pull Request #14307 · anomalyco/opencode

MakonnenMak · 2026-02-19T16:44:34Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Large # of line changes test additions.

When the client and server clocks are out of sync (e.g. browser on a local machine, server on a remote host), client-generated message IDs can sort after server-generated assistant IDs because IDs are timestamp-based. This caused two bugs:

Prompt loop never exits — the exit check compared user vs assistant message IDs by sort order. With clock skew, the user ID is always "newer" so the condition never triggers, causing 15+ loop iterations instead of 1.
Assistant messages not rendered — SessionTurn only scanned forward from the user message index to find assistant replies. With skewed IDs, the assistant sorts before the user message and was never found.

Fix: Both checks now use parentID matching instead of relying on ID/timestamp ordering:

Extracted shouldExitLoop() in prompt.ts — checks lastAssistant.parentID === lastUser.id regardless of ID sort order.
Extracted findAssistantMessages() in find-assistant-messages.tsx — scans forward first, then backward if nothing found, matching on parentID.
Removed debug console.log statements added during investigation.

I was running into this on coder.com remote environments where opencode web seemingly takes minutes to get a response back or just infinitely loops.

How did you verify your code works?

shouldExitLoop unit tests (8 cases): normal exit, clock skew exit, tool-calls, unknown, no assistant, no finish, parentID mismatch, no user
findAssistantMessages unit tests (8 cases): normal ordering, clock skew ordering, no assistant, multiple assistants, parentID mismatch, scan boundaries, invalid index
Full opencode test suite: 1110 pass, 0 fail
Full app test suite: 236 pass, 0 fail

Screenshots / recordings

N/A — no UI changes, logic-only fix.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

github-actions · 2026-02-19T16:45:36Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

github-actions · 2026-02-19T16:45:50Z

The following comment was made by an LLM, it may be inaccurate:

Found one potentially related PR:

Related PR:

PR fix: server-generated message IDs to prevent client/server clock skew #11869 — "fix: server-generated message IDs to prevent client/server clock skew"
- fix: server-generated message IDs to prevent client/server clock skew #11869
- This appears to address the same underlying clock skew issue between client and server timestamps, though from a different angle (server-generated IDs vs. parentID matching logic)

The current PR (14307) takes a different approach to solving clock skew problems by using parentID matching instead of relying on timestamp-based ID ordering. PR #11869 may have attempted a fix at the ID generation level rather than the matching logic level. You may want to check if #11869 was merged or closed to understand the context.

alexyaroshuk · 2026-02-19T17:02:09Z

packages/opencode/src/session/processor.ts

-          if (input.assistantMessage.error) return "stop"
-          return "continue"
+          const exitReason = needsCompaction ? "compact" : blocked ? "stop" : input.assistantMessage.error ? "stop" : "continue"
+          return exitReason as any


We should avoid using 'any' for typing. See Contributing guidelines

Fixed on latest commit thanks for flagging @alexyaroshuk . Unsure how to repro the windows e2e failure though, might it be flaky?

Seems like it was, new run with rebase passed 🙏🏾

MakonnenMak · 2026-02-20T18:24:11Z

There was a conflict with the base dev branch so I had to fix and rebase. Done ✅

alexyaroshuk · 2026-02-20T21:09:46Z

can't see any more issues, lgtm

MakonnenMak · 2026-02-21T16:46:05Z

@adamdotdevin wanted to bump for a review if you have some time 🙏🏾 currently blocking us from using opencode web on a coder.com remote dev env

MakonnenMak · 2026-02-24T18:48:20Z

@adamdotdevin bumping again, would be great to get this out

adamdotdevin · 2026-02-27T11:37:17Z

@rekram1-node want to get your eyes on this as well

…r prompt loop exit and message rendering

MakonnenMak · 2026-03-02T18:42:17Z

Sorry for repushing mid-review. There was a merge conflict with dev so repushed with a small import update

MakonnenMak · 2026-03-03T18:03:42Z

Hey @adamdotdevin @rekram1-node, could you take another look when you get a chance? Thanks!

MakonnenMak · 2026-03-09T18:25:21Z

Hey @adamdotdevin @rekram1-node, wanted to bump again. Thank you 🙏🏾

sjawhar · 2026-03-12T19:46:35Z

We independently arrived at the same fix (parentID matching instead of ID ordering) and adopted this approach in our fork. The shouldExitLoop extraction is clean and well-tested — we also extracted a shouldWrapSystemReminder helper for the system-reminder wrapping site, following the same pattern. Both run without issues on our end and cleanly resolve the infinite loop when client/server clocks diverge. +1 for merge.

MakonnenMak · 2026-03-17T17:38:08Z

Sorry for the noise @rekram1-node, could you take a look at this when you get a chance? It's a pretty rough experience right now with remote envs that run into this client/server clock skew problem.

MakonnenMak · 2026-03-24T19:42:32Z

Bumping again if possible @rekram1-node , happy to chat it through on the discord as well for faster communication loop 🙏🏾

opencode-agent · 2026-03-31T19:32:39Z

⚠️ Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch

Please resolve this issue to include this PR in the next beta release.

…t and message rendering When the client clock is ahead of the server, user message IDs (generated client-side) sort after assistant message IDs (generated server-side). This broke the prompt loop exit check and the UI message pairing logic. - Extract shouldExitLoop() into a pure function that uses parentID matching instead of relying on ID ordering - Extract findAssistantMessages() with forward+backward scan to handle messages sorted out of expected order due to clock skew - Remove debug console.log statements added during investigation - Add tests for both extracted functions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sjqwert · 2026-04-05T12:36:29Z

⚠️ Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge failed

Please resolve this issue to include this PR in the next beta release.

sjqwert · 2026-04-05T12:45:33Z

⚠️ Blocking Beta Release

This PR cannot be merged into the beta branch due to: Merge failed

Please resolve this issue to include this PR in the next beta release.

MakonnenMak · 2026-04-06T15:08:23Z

@sjqwert on it

…t-loop-exit # Conflicts: # packages/opencode/src/session/prompt.ts

MakonnenMak requested a review from adamdotdevin as a code owner February 19, 2026 16:44

github-actions bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Feb 19, 2026

MakonnenMak mentioned this pull request Feb 19, 2026

Running opencode web in remote dev workspaces(coder.com), looking for setup advice #13011

Closed

alexyaroshuk reviewed Feb 19, 2026

View reviewed changes

MakonnenMak force-pushed the fix/clock-skew-prompt-loop-exit branch from 0e734cb to 6f428ed Compare February 19, 2026 18:48

MakonnenMak requested a review from alexyaroshuk February 19, 2026 18:57

MakonnenMak force-pushed the fix/clock-skew-prompt-loop-exit branch from 6f428ed to fc258ea Compare February 20, 2026 18:20

adamdotdevin assigned rekram1-node Feb 27, 2026

adamdotdevin requested review from rekram1-node and removed request for alexyaroshuk February 27, 2026 11:36

adamdotdevin added the beta label Feb 27, 2026

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

f273ecd

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

e6f7034

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

d50f94e

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

2bc6e98

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

e8b1292

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

81e9a8c

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

6f27c88

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

bbf2da0

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

29d29f5

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

aa8dbb7

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Feb 27, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

0f849f7

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

1a741b1

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

7765a9c

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

adc9b06

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

76a4c43

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

e0e78ff

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

91f8ead

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

8226509

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

ee58ea2

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

e9bd197

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

80e9f9f

…r prompt loop exit and message rendering

opencode-agent bot added a commit that referenced this pull request Mar 2, 2026

Apply PR #14307: fix: use parentID matching instead of ID ordering fo…

ef61520

…r prompt loop exit and message rendering

This was referenced Mar 10, 2026

fix: resolve Claude 4.6 assistant prefill compatibility issues #16883

Closed

fix(session): use parentID instead of message ID ordering in prompt loop #17010

Open

This was referenced Mar 14, 2026

📊 AI CLI 工具社区动态日报 2026-03-14 gsscsd/big_model_radar#32

Open

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-14 compasify/agents-radar#40

Open

github-actions bot mentioned this pull request Apr 2, 2026

📊 AI CLI 工具社区动态日报 2026-04-02 gsscsd/big_model_radar#120

Open

Merge remote-tracking branch 'upstream/dev' into fix/clock-skew-promp…

291e168

…t-loop-exit # Conflicts: # packages/opencode/src/session/prompt.ts

This was referenced Apr 7, 2026

fix(session): use parentID instead of timestamp for loop exit condition #21334

Open

fix(session): use parentID instead of timestamp for loop exit condition #21365

Open

Conversation

MakonnenMak commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

alexyaroshuk Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MakonnenMak Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MakonnenMak Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

MakonnenMak commented Feb 20, 2026

Uh oh!

alexyaroshuk commented Feb 20, 2026

Uh oh!

MakonnenMak commented Feb 21, 2026

Uh oh!

MakonnenMak commented Feb 24, 2026

Uh oh!

adamdotdevin commented Feb 27, 2026

Uh oh!

MakonnenMak commented Mar 2, 2026

Uh oh!

MakonnenMak commented Mar 3, 2026

Uh oh!

MakonnenMak commented Mar 9, 2026

Uh oh!

sjawhar commented Mar 12, 2026

Uh oh!

MakonnenMak commented Mar 17, 2026

Uh oh!

MakonnenMak commented Mar 24, 2026

Uh oh!

opencode-agent bot commented Mar 31, 2026

Uh oh!

sjqwert commented Apr 5, 2026

Uh oh!

sjqwert commented Apr 5, 2026

Uh oh!

MakonnenMak commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MakonnenMak commented Feb 19, 2026 •

edited

Loading

alexyaroshuk Feb 19, 2026 •

edited

Loading

MakonnenMak Feb 19, 2026 •

edited

Loading