Skip to content

fix: put filePath before content in write tool schema #14744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harmeet wants to merge 4 commits into
base: dev
Choose a base branch
from
+5 −5
Open

fix: put filePath before content in write tool schema #14744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81e74c5
fix: put filePath before content in write tool schema
Feb 23, 2026
181e123
fix(e2e): always use forward slashes in @mention file path test
Mar 6, 2026
39e5371
fix(acp): resolve implicit any types in getContextLimit
Mar 7, 2026
73464e9
fix(file): await initial scan before returning file index
Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/app/e2e/prompt/prompt-mention.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ test("smoke @mention inserts file pill token", async ({ page, gotoSession }) =>
await gotoSession()

await page.locator(promptSelector).click()
const sep = process.platform === "win32" ? "\\" : "/"
const file = ["packages", "app", "package.json"].join(sep)
const file = ["packages", "app", "package.json"].join("/")
const filePattern = /packages[\\/]+app[\\/]+\s*package\.json/

await page.keyboard.type(`@${file}`)
Expand Down
2 changes: 1 addition & 1 deletion packages/opencode/src/acp/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export namespace ACP {
directory: string,
): Promise<number | null> {
const providers = await sdk.config
.providers({ directory })
.providers({ directory }, { throwOnError: true })
.then((x) => x.data?.providers ?? [])
.catch((error) => {
log.error("failed to get providers for context limit", { error })
Expand Down
3 changes: 2 additions & 1 deletion packages/opencode/src/file/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,11 @@ export namespace File {
cache = result
fetching = false
}
fn(cache)
const initialScan = fn(cache)

return {
async files() {
await initialScan
if (!fetching) {
fn({
files: [],
Expand Down
2 changes: 1 addition & 1 deletion packages/opencode/src/tool/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const MAX_PROJECT_DIAGNOSTICS_FILES = 5
export const WriteTool = Tool.define("write", {
description: DESCRIPTION,
parameters: z.object({
content: z.string().describe("The content to write to the file"),
filePath: z.string().describe("The absolute path to the file to write (must be absolute, not relative)"),
content: z.string().describe("The content to write to the file"),
}),
async execute(params, ctx) {
const filepath = path.isAbsolute(params.filePath) ? params.filePath : path.join(Instance.directory, params.filePath)
Expand Down
Loading