fix(opencode): write.ts coerce JSON objects to strings#14832
Open
peterdenham wants to merge 8 commits intoanomalyco:devfrom
Open
fix(opencode): write.ts coerce JSON objects to strings#14832peterdenham wants to merge 8 commits intoanomalyco:devfrom
peterdenham wants to merge 8 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, there is one potentially related PR: #7513: fix(opencode): coerce stringified JSON arrays/objects in tool parameters This PR may be related as it also addresses JSON coercion in tool parameters, though it appears to focus on already-stringified JSON rather than raw objects. You may want to review it to ensure there's no overlap or if it provides relevant context for this fix. |
6 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #6918 #1498
Type of change
What does this PR do?
When writing JSON-based file formats (
.excalidraw,.json, etc.), small/quantized models e.g. qwen3-coder, pass thecontentparameter as a native JSON object rather than a serialized string. Thez.string()schema rejects this with:I've observed at least one other model hit this error, and it by-passed the write tool and wrote the file itself. Frontier models will hit the error and will know to retry with a serialized string.
This fix adds a
z.preprocess()step that serializes any object passed ascontentto a pretty-printed JSON string before Zod validates it.This fix makes sense to me, but I'm open to hearing other solutions too.
How did you verify your code works?
The reproduction prompt
write a simple diagram in excalidraw, with a qwen3-coder model, now passes.Screenshots / recordings
n/a
Checklist