ANIMATION RETRIBUTION II: PROLAPSED OUBLIETTE#15863
Closed
kitlangton wants to merge 5 commits intoanomalyco:devfrom
Closed
ANIMATION RETRIBUTION II: PROLAPSED OUBLIETTE#15863kitlangton wants to merge 5 commits intoanomalyco:devfrom
kitlangton wants to merge 5 commits intoanomalyco:devfrom
Conversation
kitlangton
force-pushed
the
kitlangton/tool-call-abstraction-turn-diff-summary
branch
from
b7ef301 to
97dd373
Compare
Contributor
|
kitlangton
force-pushed
the
kitlangton/tool-call-abstraction-turn-diff-summary
branch
3 times, most recently
from
653cfc7 to
2e4a146
Compare
kitlangton
force-pushed
the
kitlangton/tool-call-abstraction-turn-diff-summary
branch
from
95c7fac to
4ac47ad
Compare
adamdotdevin
reviewed
Mar 6, 2026
Member
adamdotdevin
left a comment
adamdotdevin
left a comment
There was a problem hiding this comment.
let's get this merrrrrrrrged
Member
There was a problem hiding this comment.
let's swap this out with https://primitives.solidjs.community/package/resize-observer/#createelementsize (i think we already have this package installed and some usage of it)
Member
There was a problem hiding this comment.
let's swap this out with https://primitives.solidjs.community/package/page-visibility/#usepagevisibility
Member
There was a problem hiding this comment.
could replace this with https://primitives.solidjs.community/package/media/#createmediaquery
Member
There was a problem hiding this comment.
pedantic, but let's leave this untouched
Member
There was a problem hiding this comment.
again, pedantic, but would prefer this package not touched at all
…ovements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ties - Replace manual autoOpen signal+effect with hold(pending, 2000) - Extract updateScrollMask() shared by ShellExpanded and ContextToolExpandedList - Extract useCollapsible() hook for the shared expand/collapse animation pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove anim.stop() from useRowWipe cleanup — stopping mid-animation leaves WAAPI fill-forward that overrides cleared inline styles. Let animations run to completion; cancelAnimationFrame prevents starts. - Add generation counter to useCollapsible to guard against stale microtask and promise callbacks on rapid open/close toggling. - Use .then(ok, err) instead of .catch().then() to prevent callbacks firing after animation cancellation. - Remove redundant fade constant in ShellExpanded. - Clean up unused imports in context-tool-results.tsx. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrowBox,RollingResults, shared motion helpers) plus follow-up polish forTextReveal/TextShimmerand reduced-motion compliance.Key Changes
packages/ui/src/components/message-part.tsx,packages/ui/src/components/session-turn.tsx,packages/ui/src/components/basic-tool.tsx,packages/app/src/pages/session/message-timeline.tsx,packages/app/src/pages/session/session-timeline-header.tsxpackages/ui/src/components/grow-box.tsx,packages/ui/src/components/rolling-results.tsx,packages/ui/src/components/motion.tsx,packages/ui/src/components/motion-spring.tsx,packages/ui/src/components/text-reveal.tsx,packages/ui/src/components/text-shimmer.tsxpackages/ui/src/components/composer-island.tsx,packages/ui/src/components/composer-island.stories.tsx,packages/ui/src/components/session-timeline-simulator.stories.tsxpackages/ui/src/hooks/use-reduced-motion.ts,packages/ui/src/hooks/use-page-visible.ts,packages/ui/src/hooks/use-element-height.ts,packages/util/src/array.tsScope
Validation
bun turbo typecheck(run by the repo pre-push hook on the final pushes)